GA release major changes. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhangi-cs
force-pushed
the
ga_major_changes
branch
from
f22eecd to
9a5b546
Compare
| @@ -376,35 +236,14 @@ public List<Map<String, Object>> fetchTableRecordsRetryableMode(String tableName | |||
| */ | |||
| @Nullable | |||
| public Schema fetchServiceNowTableSchema(String tableName, FailureCollector collector) { | |||
There was a problem hiding this comment.
seems this can be replaced by fetchTableSchema.
There was a problem hiding this comment.
Renamed the method. 093d31e
|
|
||
| return Double.parseDouble(String.valueOf(fieldValue)); | ||
| try { | ||
| return NumberFormat.getNumberInstance(java.util.Locale.US).parse(String.valueOf(fieldValue)).doubleValue(); |
There was a problem hiding this comment.
make sure that US local parsing is expected to different regions or better to have a comment stating that US locale number format is hardcoded.
| schema = restApi.fetchTableSchema(tableName); | ||
| recordCount = restApi.getTableRecordCount(tableName); | ||
| } catch (OAuthProblemException | OAuthSystemException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Since only auth exceptions are captured so please add some user friendly message for better understanding.
Ignore if you are already handling it somewhere.
There was a problem hiding this comment.
Added an exception message. 093d31e
Formatted the code and added Javadoc. 093d31e |
sgarg-CS
force-pushed
the
ga_major_changes
branch
3 times, most recently
from
e464d65 to
bfb8fed
Compare
sgarg-CS
force-pushed
the
ga_major_changes
branch
from
cbfb212 to
ad60671
Compare
sgarg-CS
force-pushed
the
ga_major_changes
branch
from
9248f60 to
d281a19
Compare
AnkitCLI
force-pushed
the
ga_major_changes
branch
3 times, most recently
from
143b520 to
728711b
Compare
AnkitCLI
force-pushed
the
ga_major_changes
branch
from
728711b to
74af16a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GA release major changes.