Skip to content

Commit

Permalink
[CDAP-20807] Update Guava version to match google libraries needs and…
Browse files Browse the repository at this point in the history
… ensure Errors (e.g. method not found) are properly propagated.
  • Loading branch information
tivv committed Sep 19, 2023
1 parent b7abe0d commit a85d402
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ protected Map<ProvisioningOp.Status, ProvisioningSubtask> createSubTasks(
}

@Override
protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Exception e) {
protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Throwable e) {
provisionerNotifier.orphaned(programRunId);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ protected Map<ProvisioningOp.Status, ProvisioningSubtask> createSubTasks(
}

@Override
protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Exception e) {
protected void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Throwable e) {
notifyFailed(e);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public final long executeOnce() throws Exception {
return 0;
} catch (InterruptedException e) {
throw e;
} catch (Exception e) {
} catch (Throwable e) {
LOG.error("{} task failed in {} state for program run {} due to {}.",
currentTaskInfo.getProvisioningOp().getType(), state, programRunId,
Exceptions.condenseThrowableMessage(e), e);
Expand Down Expand Up @@ -231,7 +231,7 @@ protected abstract Map<ProvisioningOp.Status, ProvisioningSubtask> createSubTask
* @param taskInfo task info for the failure
* @param e the non-retryable exception
*/
protected abstract void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Exception e);
protected abstract void handleSubtaskFailure(ProvisioningTaskInfo taskInfo, Throwable e);

/**
* Logic to run when task info could not be saved to the ProvisionerStore.
Expand Down
7 changes: 4 additions & 3 deletions cdap-runtime-ext-dataproc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<!-- required by com.google.auth:google-auth-library-oauth2-http,
but set to 0.13.0 by google-cloud-dataproc for some reason -->
<version>20.0</version>
<!-- newer version required by google libs,
but set to 0.13.0 by parent pom, so put explicit version
needed by google libs -->
<version>32.1.2-jre</version>
</dependency>
<dependency>
<groupId>commons-cli</groupId>
Expand Down

0 comments on commit a85d402

Please sign in to comment.