Resolves two issues and corrects troll update #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The random function now cleanly handles changing the range while the page is loaded. The random function is now crypto secure.
Removes the troll commit made by havok2905
iargue
changed the title
|
#5 still breaks, and now indefinitely hangs on browser refresh unlike the original. This app also doesn't warrant the complexity for true random numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull corrects issue #5 and issue #4
Fixes #5 by filtering out any number not inside of the range from the chosen numbers array.
Fixes #4 by using the window.crypto.getRandomValues function.
This also removed the troll updates by havok2905 which prevented this library from working.