Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output for the Cloudwatch log group name #50

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add output for the Cloudwatch log group name #50

wants to merge 5 commits into from

Conversation

mary-sipple
Copy link

@mary-sipple mary-sipple commented Sep 4, 2024 •
edited
Loading

what

  • This feature provides an output of the cloudwatch log group name.

why

  • The log group name is needed for log ingestion into log aggregation tools.

references

@mary-sipple mary-sipple requested review from a team as code owners September 4, 2024 15:00
@mergify mergify bot added the triage Needs triage label Sep 4, 2024
RoseSecurity
RoseSecurity reviewed Sep 4, 2024
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
@RoseSecurity
Copy link
Member

/terratest

RoseSecurity
RoseSecurity approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@mergify mergify bot removed the triage Needs triage label Sep 5, 2024
@RoseSecurity RoseSecurity self-requested a review September 10, 2024 19:10
RoseSecurity
RoseSecurity requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way you could run the following to update the docs?

make init
make readme

@mergify mergify bot added the triage Needs triage label Sep 10, 2024
@mary-sipple
Copy link
Author

mary-sipple commented Sep 10, 2024 via email

@mary-sipple
Copy link
Author

mary-sipple commented Sep 23, 2024 via email

@RoseSecurity
Copy link
Member

@mary-sipple Thank you for this contribution!

@mergify mergify bot removed the triage Needs triage label Sep 23, 2024
@RoseSecurity
Copy link
Member

/terratest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoseSecurity RoseSecurity RoseSecurity approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mary-sipple @RoseSecurity