Add security field to Dogu-CR and generate SecurityContext #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still WIP, do not merge |
# Conflicts: # controllers/resource/podSpecBuilder.go
…_context_update_deployment
…_context_update_deployment
…y_context_update_deployment' into feature/221_security_context
nhinze23
reviewed
Dec 23, 2024
| @@ -42,6 +47,16 @@ const ( | |||
| DoguLabelVersion = "dogu.version" | |||
| ) | |||
|
|
|||
| // AllCapabilities are all possible values for capabilities. | |||
| var AllCapabilities = func() []Capability { | |||
There was a problem hiding this comment.
This var would fit better in the cesapp-lib
nhinze23
reviewed
Dec 23, 2024
| // AppArmorProfile defines a pod or container's AppArmor settings. | ||
| // +union | ||
| type AppArmorProfile struct { | ||
| // type indicates which kind of AppArmor profile will be applied. |
There was a problem hiding this comment.
Suggested change
| // type indicates which kind of AppArmor profile will be applied. | |
| // Type indicates which kind of AppArmor profile will be applied. |
nhinze23
reviewed
Dec 23, 2024
| // +unionDiscriminator | ||
| Type AppArmorProfileType `json:"type"` | ||
|
|
||
| // localhostProfile indicates a profile loaded on the node that should be used. |
There was a problem hiding this comment.
Suggested change
| // localhostProfile indicates a profile loaded on the node that should be used. | |
| // LocalhostProfile indicates a profile loaded on the node that should be used. |
nhinze23
reviewed
Dec 23, 2024
| }{ | ||
| {"valid empty", args{&Dogu{}}, assert.NoError}, | ||
| {"valid add filled", args{&Dogu{Spec: DoguSpec{Security: Security{Capabilities: Capabilities{Add: []Capability{core.AuditControl}}}}}}, assert.NoError}, | ||
| {"valid add filled", args{&Dogu{Spec: DoguSpec{Security: Security{Capabilities: Capabilities{Drop: []Capability{core.AuditControl}}}}}}, assert.NoError}, |
There was a problem hiding this comment.
Suggested change
| {"valid add filled", args{&Dogu{Spec: DoguSpec{Security: Security{Capabilities: Capabilities{Drop: []Capability{core.AuditControl}}}}}}, assert.NoError}, | |
| {"valid drop filled", args{&Dogu{Spec: DoguSpec{Security: Security{Capabilities: Capabilities{Drop: []Capability{core.AuditControl}}}}}}, assert.NoError}, |
nhinze23
reviewed
Dec 23, 2024
| seccompProfile := seccompProfile(doguResource.Spec.Security.SeccompProfile) | ||
|
|
||
| readOnlyRootFS := isReadOnlyRootFS(dogu, doguResource) | ||
| // We never want those to be true and don't respect the dogu descriptor's privileged flag which is deprecated anyway. |
There was a problem hiding this comment.
Nice 👍 This flag was only used by the registrator dogu which is no longer needed.
nhinze23
reviewed
Dec 23, 2024
| SecurityContext: &corev1.SecurityContext{ | ||
| Capabilities: &corev1.Capabilities{ | ||
| Drop: []corev1.Capability{"ALL"}, | ||
| Add: []corev1.Capability{"CHOWN"}, |
There was a problem hiding this comment.
The init container also needs DAC_OVERRIDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #221