Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Deps #4

Closed
wants to merge 1 commit into from
Closed

Update Deps #4

wants to merge 1 commit into from

Conversation

sakgoyal
Copy link

  • fix axios security issues by updating dep
  • fix all TS errors after upgrading versions
  • Make all interfaces Uppercase for consistency
  • remove deprecated Jest function toThrowError with toThrow
  • enable extra TS safety configs

sakgoyal
sakgoyal commented Jan 20, 2024
View reviewed changes
src/messageClient.ts

default:
return new errors.CloudMailinError(error.message, error);
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant code

@scsmith
Copy link
Contributor

scsmith commented Jan 23, 2024

Apologies for the delay here. I'll have a look at updating the Axios requirement. I'm not 100% sure about forcing the upgrade of Typescript etc at the same time. We'll spend some time discussing this and see where we land today.

This also applies to #3

@scsmith
Copy link
Contributor

scsmith commented Jan 23, 2024

Fixed by #5

@scsmith scsmith closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakgoyal @scsmith