Breaking Change: Remove unnecessary env vars #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the LOG_CACHE_ADDR env var as an option for telling the plugin where to look for Log Cache. This is a relic of when the plugin had a dual function as a standalone CLI, and is no longer necessary since the plugin can always fetch the Log Cache address from the targeted CF API.
mkocher
approved these changes
Feb 2, 2024
Removes the LOG_CACHE_SKIP_AUTH env var as an option for telling the plugin not to use authentication headers in requests. This is a relic of when the plugin had a dual function as a standalone CLI, and is no longer necessary. Log Cache should always require authentication headers, which can be easily fetched with cf CLI connection methods.
ctlong
force-pushed
the
breaking/remove-unnecessary-env-vars
branch
from
cdbd571 to
42733f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #178.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack