Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mysql 5.7 from unit tests #4018

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove mysql 5.7 from unit tests #4018

wants to merge 1 commit into from

Conversation

stephanme
Copy link
Contributor

  • A short explanation of the proposed change:

Take out mysql 5.7 from the unit test matrix as it is explicitly not supported for cf-deployment.

  • An explanation of the use cases your change solves

Allows to use mysql features and rely on bug fixes that are not available in mysql 5.7.
Example: Dropping of duplicated unique constraints in DB migrations.

  • Links to any other associated PRs

Fixes #3949 and unblocks #3952

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@stephanme stephanme requested a review from sethboyles October 11, 2024 09:11
@sethboyles
Copy link
Member

Our preference would be to hold off on this until May, as we support foundations using MySQL 5.7 until then.

@stephanme
Copy link
Contributor Author

OK, we need then to adapt #3949 to work with mysql 5.7.
Labeled it as blocked until May 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mysql5.7 support / remove Mysql5.7 from PR validation
2 participants