Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Introduce experimental use_optimized_json_encoder configurati… #265

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

moleske
Copy link
Member

@moleske moleske commented Aug 19, 2022

…on (#208)"

This reverts commit 28d6e39.

Thanks for contributing to the capi_release. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    remove experimental use optimized json encoder as it will be the only one

  • An explanation of the use cases your change solves

  • Links to any other associated PRs
    replace multijson with Oj in config/initializers/json #encode cloud_controller_ng#2930 would need to be merged at the same time as that actually removed usage of it

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

@moleske moleske marked this pull request as ready for review August 19, 2022 18:50
Copy link
Contributor

@johha johha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethboyles sethboyles merged commit 2c8b96f into develop Aug 24, 2022
@moleske moleske deleted the remove-expiermental-use-optimized-json-encoder branch August 26, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants