Use blobs in integration specs instead of bucket artifacts #2582
+235
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
reviewed
Nov 9, 2024
ystros
force-pushed
the
use-blobs-in-integration
branch
3 times, most recently
from
2c2369e
to
419a48c
Compare
aramprice
force-pushed
the
use-blobs-in-integration
branch
2 times, most recently
from
48a038e
to
5cee757
Compare
ystros
force-pushed
the
use-blobs-in-integration
branch
6 times, most recently
from
4269c3f
to
0e628e4
Compare
jpalermo
requested review from
a team,
aramprice and
a-hassanin
and removed request for
a team
The version of verify-multidigest being downloaded from the bucket is hardcoded and many versions behind the one currently used by the real BOSH Director. This removes the ability to run integration specs on a Mac because the blob only includes a compiled linux binary.
Also make spacing consistent
The nats-server binary replaced the legacy forked gnatsd binary in 2022: #2391 However, the integration specs were still using an old version of gnatsd from an S3 bucket. Now, the integration specs use the current nats-server blob directly. This required allowing all users connecting to the NATS server to subscribe and publish to any channel, because the integration specs require an admin-level user but the nats-sync process does not allow custom users (only the Director, Health Monitor, and individual agents).
* config-server and bosh-agent repos are now required to be cloned at the same level as the bosh repo * Services and binaries are only compiled once Signed-off-by: Aram Price <[email protected]>
Signed-off-by: Aram Price <[email protected]>
Signed-off-by: Aram Price <[email protected]>
ystros
force-pushed
the
use-blobs-in-integration
branch
from
0e628e4
to
bd57b05
Compare
|
Latest force push rebases against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
We are making an effort to consolidate or eliminate buckets from various pipelines across the ecosystem. Currently the integration specs download several artifacts from S3 buckets. Some of the artifacts being downloaded did not represent the current version used in the Director, such as the NATS server.
Instead of downloading these artifacts from out-of-date buckets, the binaries are extracted from the Director blobs directly. The config server binary must now be provided via environment variables because it is not a blob, and is only used in testing.
One notable change is that since only Linux versions of binaries are included in the current blobs, it is not possible to run the integration specs on a Mac. The previous code appears to have allows running on a Mac, though I personally could not get it to work.
What tests have you run against this PR?
bundle exec rake fly:integration