Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to disable the '-auto-approve' option with terraform #617

Merged

Conversation

mdimiceli
Copy link
Contributor

With the current settings, when we run the bbl up command, it calls terraform apply -auto-approve. In some cases, knowing that we're working with other people, some applied changes may not be something we want to apply in our infrastructure. So we'd like to be able to approve changes ourselves instead of having them applied automatically.

The apply and destroy terraform commands are always used with the -auto-approve option. Before using this option, it is recommended that you make sure that nobody else can modify the infrastructure outside the Terraform workflow.

This feature adds the ability to disable automatic approval when using terraform by adding the --disable-tf-auto-approve option and the BBL_DISABLE_TF_AUTO_APPROVE environment variable.

@rkoster rkoster requested review from a team, xtreme-nitin-ravindran, nader-ziada and ramonskie and removed request for a team September 5, 2024 15:06
Copy link
Contributor

@nader-ziada nader-ziada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change makes sense, ran the tests and tried the cli and all works as expected

@jpalermo jpalermo merged commit 846de1b into cloudfoundry:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants