-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS assume role #611
AWS assume role #611
Conversation
Initial commit. Includes: BBL assuming the role while terraforming and the iaas interactions between bbl and aws. Missing: using the ops file found in bosh-deployment: `aws/cpi-assume-role-credentials.yml` to make the AWS CPI use the role. Unit tests/Integration tests.
If the AWS assume role ARN is set, the scripts to create both the BOSH Director and jumpbox need to pass additional ops files and variables. [#184999423] Add AssumeRole support to bbl
[#184999423] Add AssumeRole support to bbl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some linting errors
Never mind, the linting errors are unrelated to this PR
About
I am looking to use AWS Assume Role with
bbl
. I see there has been some work done in the past to add this support in (see the aws-assume-role-support branch), however it looks like that work never got merged intomain
.I tried it out myself by rebasing that branch on top of
main
and building a local copy to see if it would work. I was able to successfullybbl up
a director using theBBL_AWS_ASSUME_ROLE
env var so thought I'd open this PR to get that work merged in.cc @danielfor and @ystros who originally contributed the commits to the aws-assume-role-support branch.