-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add XFCC authenticated eventgenerator endpoint #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 15, 2024 12:12
281fab0
to
bd34b1c
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
from
November 18, 2024 12:13
0bdb2c9
to
a427b67
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 18, 2024 12:14
bd34b1c
to
29976fb
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
from
November 21, 2024 10:41
a427b67
to
0c75c63
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 21, 2024 10:41
8d2e7ea
to
b5238d2
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
from
November 21, 2024 12:30
29d66c0
to
9dcb3fd
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 21, 2024 12:33
b5238d2
to
0607dfe
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
2 times, most recently
from
November 25, 2024 14:48
532722b
to
1875d2e
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 25, 2024 14:49
0607dfe
to
05c7cc4
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-scaling-engine
branch
from
November 27, 2024 12:36
1875d2e
to
ca3f8c5
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 27, 2024 14:58
05c7cc4
to
2e40292
Compare
Co-authored-by: Silvestre Zabala <[email protected]>
Co-authored-by: Silvestre Zabala <[email protected]>
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
November 28, 2024 10:09
40028b5
to
00083e4
Compare
Quality Gate failedFailed conditions |
silvestre
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new xfcc unified endpoint to the eventgenerator that will be consumed by the API component once it is deployed as a Cloud Foundry application.
New CF Server Support:
jobs/eventgenerator/spec
: Added new properties for the CF server, includingport
,xfcc.valid_org_guid
, andxfcc.valid_space_guid
with default values.jobs/eventgenerator/templates/eventgenerator.yml.erb
: Updated the template to include the new CF server properties.operations/use-cf-services.yml
: Added configurations to enable the CF server and route registrar for theeventgenerator
.Makefile and Cleanup:
Makefile
: Added a new targetclean-fakes
to remove directories named "fakes".Test Enhancements:
spec/jobs/eventgenerator/eventgenerator_spec.rb
: Added tests to verify the default port andxfcc
properties for the CF server.src/autoscaler/eventgenerator/cmd/eventgenerator/eventgenerator_test.go
: Refactored tests to include the CF server and ensure proper initialization and cleanup. [1] [2]Configuration and Initialization:
src/autoscaler/build-extension-file.sh
: Added environment variables and resources for the CF server. [1] [2]src/autoscaler/eventgenerator/cmd/eventgenerator/main.go
: Updated the main function to create and start the CF server with proper middleware. [1] [2]These changes collectively enhance the
eventgenerator
component by adding support for a CF server, improving configuration management, and ensuring comprehensive test coverage.