fix(apiserver) Handle NPE for Custom Metrics Strategy #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
added
the
allow-acceptance-tests
asalan316
force-pushed
the
fix-servicebinding-npe
branch
from
13e6c29 to
e6be753
Compare
asalan316
changed the title
asalan316
force-pushed
the
fix-servicebinding-npe
branch
from
e6be753 to
dfd049f
Compare
|
silvestre
approved these changes
Nov 6, 2024
asalan316
added
bug
and removed
allow-acceptance-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The apiserver throws type conversion error if the custom metric strategy is defined as null or empty in the existing binding table.
FIX
Allow empty/null values for custom metrics strategy in the binding.