Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asdf2devbox): Switch to Java 21 #3136

Merged
merged 2 commits into from
Aug 16, 2024
Merged

chore(asdf2devbox): Switch to Java 21 #3136

merged 2 commits into from
Aug 16, 2024

Conversation

silvestre
Copy link
Member

Issue

As the Nix package name contains the Java major version, the translation
needs to be updated now that we have switched to version 21

Fix

Just a static string change. Parsing it from the version number would be
possible, but as it is a LTS release the next update should be in the
far future.

@silvestre silvestre added the dependencies Pull requests that update a dependency file label Aug 16, 2024
# Issue

As the Nix package name contains the Java major version, the translation
needs to be updated now that we have switched to version 21

# Fix

Just a static string change. Parsing it from the version number would be
possible, but as it is a LTS release the next update should be in the
far future.
Copy link

@silvestre silvestre marked this pull request as ready for review August 16, 2024 13:03
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@silvestre silvestre merged commit 8b393ff into main Aug 16, 2024
30 checks passed
@silvestre silvestre deleted the bump-temurin-to-21 branch August 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants