Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cred_helper): Check app isolation in stored_procedure cred_helper #3134

Merged
merged 24 commits into from
Aug 16, 2024
Merged

fix(cred_helper): Check app isolation in stored_procedure cred_helper #3134

merged 24 commits into from
Aug 16, 2024

Conversation

joergdw
Copy link
Contributor

@joergdw joergdw commented Aug 16, 2024

No description provided.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@joergdw joergdw force-pushed the patch_app-isolation branch 2 times, most recently from 7189456 to b36d811 Compare August 16, 2024 08:56
@joergdw joergdw marked this pull request as ready for review August 16, 2024 08:57
@joergdw joergdw requested a review from silvestre August 16, 2024 08:57
silvestre
silvestre approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@silvestre silvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions.

src/autoscaler/db/sqldb/storedprocedure_sqldb.go Outdated Show resolved Hide resolved
src/autoscaler/db/sqldb/storedprocedure_sqldb.go Outdated Show resolved Hide resolved
src/autoscaler/db/sqldb/storedprocedure_sqldb.go Outdated Show resolved Hide resolved
src/autoscaler/db/sqldb/storedprocedure_sqldb.go Show resolved Hide resolved
@joergdw joergdw force-pushed the patch_app-isolation branch from cd1c00c to e220bee Compare August 16, 2024 12:33
@joergdw
Copy link
Contributor Author

joergdw commented Aug 16, 2024

I had to rebase, due to EasyCLA of commit e45bd5e not being compliant. That was a nightmare! The history now is totally screwed up. Commit-messages don't fit, the order does not fit, intermediate commits are broken… but the final result looks fine.

joergdw and others added 13 commits August 16, 2024 15:27
@joergdw
✒️ Implement credential-check;
85b4d94
@joergdw
🔧 Fix sqldb-tests;
e9773fd
@joergdw
🔧 Fix missing initalisations of bindingDB for the credential-helper;
a0d4eaa
@joergdw
🔧 Fix metricsforwarder-unit-test;
e1dc3be
@joergdw
🩹 Add bosh-package-configuration for the new binding-db-connection of…
0d2a581 
… metricsforwarder.
@joergdw
Include review-findings;
f19c3e6
@joergdw
Remove now obsolet changes that came in with older revisions.
71caec6 
The following revisions are largely reverted by this one:
 + b2e17a3
 + 559a210
 + 7bdfb3a
@joergdw
🔧 Fix SQL-query;
000a39e
@joergdw
Rename: Database.DSN ↦ Database.DataSourceName
ca9afa8
@joergdw
Merge branch 'main' into HASI2024173-22.fix-cross-app-guid-auth.stable
f26288f
@joergdw @silvestre
Apply suggestions from code review
2e3661c 
Add suggestions from review.

Co-authored-by: Silvestre Zabala <[email protected]>
@joergdw
🔧 Fix dependency for performance-test-setup;
ed21742
@joergdw
Remove superfluous case-treatment;
c2ee4c6
@joergdw joergdw force-pushed the patch_app-isolation branch from e7d83d8 to c2ee4c6 Compare August 16, 2024 13:34
@joergdw
Copy link
Contributor Author

joergdw commented Aug 16, 2024

Merge-commits screw everything up, when they are included. 😞 . Next try to make “Easy”CLA happy

@silvestre silvestre added the bug label Aug 16, 2024
@joergdw joergdw added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed bug labels Aug 16, 2024
@joergdw joergdw force-pushed the patch_app-isolation branch from b8827a9 to 3edc13f Compare August 16, 2024 15:59
@joergdw joergdw force-pushed the patch_app-isolation branch from e248b5c to a28998e Compare August 16, 2024 16:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@joergdw joergdw enabled auto-merge August 16, 2024 16:34
@joergdw joergdw merged commit acf4f0c into main Aug 16, 2024
27 of 28 checks passed
@joergdw joergdw deleted the patch_app-isolation branch August 16, 2024 17:06
@silvestre silvestre added the bug label Aug 19, 2024
@silvestre silvestre changed the title Patch app-isolation fix(cred_helper): Check app isolation in stored_procedure cred_helper Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvestre silvestre silvestre approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joergdw @silvestre @app-autoscaler-ci-bot