Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix fly param value assignment so that make delete-pipeline works #3031

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

geigerj0
Copy link
Contributor

@geigerj0 geigerj0 commented Jun 18, 2024

Problem

The additional space between param and value assignment breaks make delete-pipeline

make delete-pipeline                   
+ target=app-autoscaler-release
+ check-login
+ fly -t app-autoscaler-release status
logged in successfully
+ delete-pipeline ''
++ fly  👹--target= app-autoscaler-release pipelines👹  --json 
error: Unknown command `app-autoscaler-release'. Please specify one command of: abort-build, active-users, archive-pipeline, builds, check-resource, check-resource-type, checklist, clear-resource-cache, clear-task-cache, clear-versions, completion, containers, curl, delete-target, destroy-pipeline, destroy-team, disable-resource-version, edit-target, enable-resource-version, execute, expose-pipeline, format-pipeline, get-pipeline, get-team, help, hide-pipeline, hijack, jobs, land-worker, login, logout, order-instanced-pipelines, order-pipelines, pause-job, pause-pipeline, paused-jobs, paused-pipelines, pin-resource, pipelines, prune-worker, rename-pipeline, rename-team, rerun-build, resource-versions, resources, schedule-job, set-pipeline, set-team, status, sync, targets, teams, trigger-job, unpause-job, unpause-pipeline, unpin-resource, userinfo, validate-pipeline, volumes, watch or workers
+ payload=
make: *** [Makefile:13: delete-pipeline] Error 1

Solution

Deleting the faulty extra space so thatmake delete-pipeline works.

@geigerj0 geigerj0 added exclude-from-changelog allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Jun 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@geigerj0 geigerj0 changed the title fix(ci): fix fly param value assignment so thatmake delete-pipeline works fix(ci): fix fly param value assignment so that make delete-pipeline works Jun 18, 2024
@bonzofenix bonzofenix self-requested a review June 18, 2024 08:20
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geigerj0 geigerj0 enabled auto-merge (squash) June 18, 2024 08:22
@geigerj0 geigerj0 disabled auto-merge June 18, 2024 13:28
@geigerj0 geigerj0 enabled auto-merge (squash) June 18, 2024 13:29
@geigerj0 geigerj0 disabled auto-merge June 18, 2024 13:29
@geigerj0 geigerj0 merged commit 536f3d0 into main Jun 18, 2024
32 of 34 checks passed
@geigerj0 geigerj0 deleted the fix-delete-pipeline branch June 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. exclude-from-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants