feat(healthendpoint): Refactor health endpoint in all services to run on same port as main service #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
2 times, most recently
from
dc4566c to
bedbdbc
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/autoscaler/eventgenerator/cmd/eventgenerator/eventgenerator_test.go
Outdated
Show resolved
Hide resolved
src/autoscaler/eventgenerator/cmd/eventgenerator/eventgenerator_suite_test.go
Outdated
Show resolved
Hide resolved
src/autoscaler/eventgenerator/cmd/eventgenerator/eventgenerator_test.go
Outdated
Show resolved
Hide resolved
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
4 times, most recently
from
2085fa2 to
cbaa084
Compare
src/autoscaler/scalingengine/cmd/scalingengine/scalingengine_test.go
Outdated
Show resolved
Hide resolved
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
2 times, most recently
from
ffaf165 to
bd90ac7
Compare
bonzofenix
changed the title
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
10 times, most recently
from
41a044c to
636b653
Compare
bonzofenix
added
the
allow-acceptance-tests
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
3 times, most recently
from
2d9aaba to
9417582
Compare
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
from
f6d8da4 to
d586408
Compare
…gine in app-autoscaler.yml
- Remove hardcoded paths and replace with dynamic URL construction using `fmt.Sprintf` and `url.Parse` - Consolidate constants for API paths into the tests where they are used - Eliminate unused variables and imports following the URL refactoring - Update functions to construct URLs dynamically before making HTTP requests
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
2 times, most recently
from
8f7631a to
c49eca2
Compare
bonzofenix
force-pushed
the
feature/754-healthendpoint-service-refactor
branch
from
c49eca2 to
45d9256
Compare
• Update tests to construct serverUrl as a url.URL object instead of a string. • Simplify the request setup by removing redundant helper functions and using setupRequest directly. • Set basic auth credentials on the request using SetBasicAuth method. • Adjust serverUrl.Path for each test case to point to the correct endpoint.
…ith When for test descriptions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
MTLS verification is performed server-side for communication in between App Autoscaler components. To prepare components to run as Cloud Foundry (CF) apps on SAP BTP, we need to merge the health and service ports for each service, as there is no TCP routing enabled. The
/healthendpoints in each CF Autoscaler component are monitored by our Cloud Engineering Team and must remain available without MTLS requirements. When migrating apps from BOSH VMs to CF, apps can only listen on a single port in the container. Therefore, thehealthendpoint and/health metrics must be available on the same service of the server.Whats new
• Basic Authentication Implementation: Introduced basic authentication for multiple components, including scaling engine, event generator, and operator.
• OpenAPI Specification Enhancements: Added new API endpoints for scaling history and improved existing API structures.
• Prometheus Integration: Enhanced health monitoring with Prometheus metrics collection for various services.
• Refactoring and Code Cleanup: Streamlined code by removing unused dependencies and consolidating authentication logic.
• Testing Improvements: Expanded test coverage for new authentication mechanisms and API endpoints.
• Configuration Management: Updated configuration files to reflect new authentication parameters and removed deprecated settings.
Why should we merge this PR in one go
Why we would not want to merge this PR
Out of scope