Fix concourse acceptance

Makefile

@@ -2,7 +2,13 @@ SHELL := /bin/bash
 .SHELLFLAGS := -eu -o pipefail -c ${SHELLFLAGS}
 MAKEFLAGS = -s
 
-go_modules := $(shell  find . -maxdepth 3 -name "*.mod" -exec dirname {} \; | sed 's|\./src/||' | sort)
+go-acceptance-dir := ./src/acceptance
+go-autoscaler-dir := ./src/autoscaler
+go-changelog-dir := ./src/changelog
+go-changeloglockcleander-dir := ./src/changeloglockcleaner
+go-test-app-dir := ./src/acceptance/assets/app/go_app
+
+go_modules := $(shell find . -maxdepth 3 -name "*.mod" -exec dirname {} \; | sed 's|\./src/||' | sort)
 all_modules := $(go_modules) db scheduler
 
 MVN_OPTS = "-Dmaven.test.skip=true"
@@ -23,7 +29,8 @@ CI ?= false
 VERSION ?= 0.0.testing
 DEST ?= build
 
-GOLANGCI_LINT_VERSION = v$(shell cat .tool-versions | grep golangci-lint  | cut --delimiter=' ' --fields='2')
+GOLANGCI_LINT_VERSION = v$(shell cat .tool-versions | grep golangci-lint  \
+													| cut --delimiter=' ' --fields='2')
 
 export BUILDIN_MODE ?= false
 export DEBUG ?= false
@@ -257,18 +264,17 @@ acceptance-release: clean-acceptance go-mod-tidy vendor build-test-app
 	@mkdir -p ${DEST}
 	@tar --create --auto-compress --directory="src" --file="${ACCEPTANCE_TESTS_FILE}" 'acceptance'
 
-
+.PHONY: generate-fakes autoscaler.generate-fakes test-app.generate-fakes
+generate-fakes: autoscaler.generate-fakes test-app.generate-fakes
+autoscaler.generate-fakes:
+	make --directory='${go-autoscaler-dir}' generate-fakes
+test-app.generate-fakes:
+	make --directory='${go-test-app-dir}' generate-fakes
 
 .PHONY: go-mod-tidy
 go-mod-tidy: acceptance.go-mod-tidy autoscaler.go-mod-tidy changelog.go-mod-tidy \
 						 changeloglockcleander.go-mod-tidy test-app.go-mod-tidy
 
-go-acceptance-dir := ./src/acceptance
-go-autoscaler-dir := ./src/autoscaler
-go-changelog-dir := ./src/changelog
-go-changeloglockcleander-dir := ./src/changeloglockcleaner
-go-test-app-dir := ./src/acceptance/assets/app/go_app
-
 .PHONY: acceptance.go-mod-tidy autoscaler.go-mod-tidy changelog.go-mod-tidy \
 				changeloglockcleander.go-mod-tidy test-app.go-mod-tidy
 acceptance.go-mod-tidy:

ci/autoscaler/pipeline.yml

@@ -26,7 +26,6 @@ anchors:
       operations/remove-metricsgateway.yml
       operations/enable-scheduler-logging.yml
 
-
   app-autoscaler-ops-files-upgrade: &app-autoscaler-ops-files-upgrade
     OPS_FILES: |
       operations/add-releases.yml
@@ -234,9 +233,10 @@ jobs:
       trigger: true
     - get: ci
   - task: make-prerelease
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
-      TARGETS: go-mod-tidy vendor db scheduler
+      # ⚠️ Here it is used that make officially guarantees to reach the goals in the provided order.
+      TARGETS: generate-fakes go-mod-tidy go-mod-vendor db scheduler
   - task: deploy-autoscaler
     file: ci/ci/autoscaler/tasks/deploy-autoscaler.yml
     params:
@@ -280,9 +280,10 @@ jobs:
       trigger: true
     - get: ci
   - task: make-prerelease
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
-      TARGETS: go-mod-tidy vendor db scheduler
+      # ⚠️ Here it is used that make officially guarantees to reach the goals in the provided order.
+      TARGETS: generate-fakes go-mod-tidy go-mod-vendor db scheduler
   - task: deploy-autoscaler
     file: ci/ci/autoscaler/tasks/deploy-autoscaler.yml
     params:
@@ -328,9 +329,10 @@ jobs:
       trigger: true
     - get: ci
   - task: make-prerelease
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
-      TARGETS: go-mod-tidy vendor db scheduler
+      # ⚠️ Here it is used that make officially guarantees to reach the goals in the provided order.
+      TARGETS: generate-fakes go-mod-tidy go-mod-vendor db scheduler
   - task: deploy-autoscaler
     file: ci/ci/autoscaler/tasks/deploy-autoscaler.yml
     params:
@@ -365,9 +367,10 @@ jobs:
     - get: bbl-state
     - get: app-autoscaler-release
   - task: make-prerelease
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
-      TARGETS: go-mod-tidy vendor db scheduler
+      # ⚠️ Here it is used that make officially guarantees to reach the goals in the provided order.
+      TARGETS: generate-fakes go-mod-tidy go-mod-vendor db scheduler
   - task: deploy-autoscaler
     file: ci/ci/autoscaler/tasks/deploy-autoscaler.yml
     params:
@@ -378,11 +381,11 @@ jobs:
     params:
       <<: *performance-env
   - task: setup-performance
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
      TARGETS: setup-performance
   - task: run-performance
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
      TARGETS: run-performance
 
@@ -422,9 +425,10 @@ jobs:
         pre_upgrade
       NODES: 1
   - task: make-prerelease
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
-      TARGETS: go-mod-tidy vendor db scheduler
+      # ⚠️ Here it is used that make officially guarantees to reach the goals in the provided order.
+      TARGETS: generate-fakes go-mod-tidy go-mod-vendor db scheduler
   - task: deploy-autoscaler
     file: ci/ci/autoscaler/tasks/deploy-autoscaler.yml
     params:
@@ -451,9 +455,10 @@ jobs:
       passed: [upgrade-test]
     - get: ci
   - task: make-prerelease
-    file: ci/ci/autoscaler/tasks/make/make.yml
+    file: ci/ci/autoscaler/tasks/make/make.yaml
     params:
-      TARGETS: go-mod-tidy vendor db scheduler
+      # ⚠️ Here it is used that make officially guarantees to reach the goals in the provided order.
+      TARGETS: generate-fakes go-mod-tidy go-mod-vendor db scheduler
   - task: release-autoscaler
     file: ci/ci/autoscaler/tasks/release-autoscaler.yml
     params:

ci/autoscaler/tasks/make/make.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
 # shellcheck disable=SC2086
-set -euo pipefail
+set -eu -o pipefail
 
-make -C $1 ${TARGETS}
+make --directory="${1}" ${TARGETS}