Review Fixes

Makefile

@@ -358,7 +358,7 @@ mta-release: mta-build
 	@echo " - building mtar release '${VERSION}' to dir: '${DEST}' "
 
 .PHONY: acceptance-release
-acceptance-release: generate-fakes  generate-openapi-generated-clients-and-servers clean-acceptance go-mod-tidy go-mod-vendor build-test-app
+acceptance-release: clean-acceptance go-mod-tidy go-mod-vendor build-test-app
 	@echo " - building acceptance test release '${VERSION}' to dir: '${DEST}' "
 	@mkdir -p ${DEST}
 	${AUTOSCALER_DIR}/scripts/compile-acceptance-tests.sh

src/autoscaler/models/binding_configs_test.go

@@ -8,7 +8,9 @@ import (
 
 var _ = Describe("BindingConfigs", func() {
 
-	Describe("GetBindingConfigAndPolicy", func() {
+	var bindingConfig *BindingConfig
+
+	Context("GetBindingConfigAndPolicy", func() {
 		var (
 			scalingPolicy        *ScalingPolicy
 			customMetricStrategy string
@@ -20,7 +22,7 @@ var _ = Describe("BindingConfigs", func() {
 			result, err = GetBindingConfigAndPolicy(scalingPolicy, customMetricStrategy)
 		})
 
-		Context("when both scaling policy and custom metric strategy are present", func() {
+		When("both scaling policy and custom metric strategy are present", func() {
 			BeforeEach(func() {
 				scalingPolicy = &ScalingPolicy{
 					InstanceMax: 5,
@@ -48,7 +50,7 @@ var _ = Describe("BindingConfigs", func() {
 			})
 		})
 
-		Context("when only scaling policy is present", func() {
+		When("only scaling policy is present", func() {
 			BeforeEach(func() {
 				scalingPolicy = &ScalingPolicy{
 					InstanceMax: 5,
@@ -73,7 +75,7 @@ var _ = Describe("BindingConfigs", func() {
 			})
 		})
 
-		Context("when policy is not found", func() {
+		When("policy is not found", func() {
 			BeforeEach(func() {
 				scalingPolicy = nil
 				customMetricStrategy = CustomMetricsBoundApp
@@ -86,10 +88,6 @@ var _ = Describe("BindingConfigs", func() {
 		})
 	})
 
-	var (
-		bindingConfig *BindingConfig
-	)
-
 	Context("GetCustomMetricsStrategy", func() {
 		It("should return the correct custom metrics strategy", func() {
 			bindingConfig = &BindingConfig{