Skip to content

Commit

Permalink
chore(ci): Add auto-approve step for PRs by renovate[bot] (#2839)
Browse files Browse the repository at this point in the history
* chore(ci): Add auto-approve step for PRs by renovate[bot]

# Issue

After activating the CFF default `main` branch protection rule, reviews
get dismissed if the PR diff changes. As our automated dependency PR
post-processing might do exactly that, it needs to reapprove the PR.

# Fix

Auto-approve dependabot PRs if our PR post-processing has modified the
PR.

# Remarks

Addtionally, this PR removes obsolete workflows:

- `.dependency-spec-updates.yaml` became obsolete with the introduction of `dependency-update.go-mod-tidy_and_make-package-specs.yaml` and never worked afterwards: https://github.com/cloudfoundry/app-autoscaler-release/actions/workflows/dependency-spec-updates.yaml - the green runs are where it didn't have to do anything because it was already taken care of by `dependency-update.go-mod-tidy_and_make-package-specs.yaml`
- `dependency-updates-auto-merge.yaml` had two jobs: Approving `dependabot` PRs, which we disabled in favor of `renovate` and enabling automerge which `renovate` also takes care of itself.
  • Loading branch information
silvestre authored Apr 12, 2024
1 parent e3508c1 commit d02b7b8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 64 deletions.
31 changes: 0 additions & 31 deletions .github/workflows/dependency-spec-updates.yaml

This file was deleted.

30 changes: 0 additions & 30 deletions .github/workflows/dependency-updates-auto-merge.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "renovate-/ospo-bot: go mod tidy and make package-specs"
name: "Dependency Updates Post-Processing"
on:
pull_request:
branches:
Expand All @@ -22,8 +22,9 @@ on:
- "src/**/go.sum"
workflow_dispatch: {}
jobs:
pkgs-specs_and_go-mod-tidy:
name: "go mod tidy && make package-specs"
dependency-updates-post-processing:
if: github.actor == 'renovate[bot]'
name: "Dependency Updates Post-Processing"
runs-on: ubuntu-latest
container:
image: ghcr.io/cloudfoundry/app-autoscaler-release-tools:main
Expand Down Expand Up @@ -103,3 +104,5 @@ jobs:
echo 'No files changed!'
fi
echo '🏁'
- name: Auto-approve
uses: hmarr/auto-approve-action@v4

0 comments on commit d02b7b8

Please sign in to comment.