fix(test): Fix scalingengine_sqldb_test.go

# Issue The ScalingEngineSqldb tests had become flaky # Fix A well-meaning but harmfull test cleanup function was removed.
cloudfoundry · Aug 28, 2024 · 94416f2 · 94416f2
1 parent 7d732de
commit 94416f2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/autoscaler/db/sqldb/scalingengine_sqldb_test.go b/src/autoscaler/db/sqldb/scalingengine_sqldb_test.go
@@ -73,12 +73,10 @@ var _ = Describe("ScalingEngineSqldb", func() {
 		cleanupForApp(appId)
 		cleanupForApp(appId2)
 		cleanupForApp(appId3)
-		cleanUpCooldownTable()
 		DeferCleanup(func() {
 			cleanupForApp(appId)
 			cleanupForApp(appId2)
 			cleanupForApp(appId3)
-			cleanUpCooldownTable()
 		})
 	})
 

diff --git a/src/autoscaler/db/sqldb/sqldb_suite_test.go b/src/autoscaler/db/sqldb/sqldb_suite_test.go
@@ -210,11 +210,6 @@ func removeCooldownForApp(appId string) {
 	FailOnError("can not remove scalingcooldown for app", err)
 }
 
-func cleanUpCooldownTable() {
-	_, err := dbHelper.Exec("DELETE from scalingcooldown")
-	FailOnError("can not clean table scalingcooldown", err)
-}
-
 func removeActiveScheduleForApp(appId string) {
 	query := dbHelper.Rebind("DELETE from activeschedule where appId = ?")
 	_, err := dbHelper.Exec(query, appId)