set staging_memory_in_mb and staging_disk_in_mb during build #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation for creating the build does not set the staging_memory_in_mb and staging_disk_in_mb arguments. Consequently, the allocated memory and disk space for staging the build remain at the default of 1G, leading to issues where staging runs out of memory in some cases.
To fix this
Similar to the apply_manifest deployment process, the memory and disk configurations of an application will be utilized for the staging process. Therefore, we will adopt this approach and use the application's memory and disk values for staging.