Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default app name on 'About' page is always 'Zuun' #105

Merged

Conversation

bmo-at-a9s
Copy link
Contributor

Description

I removed a line likely left in as a debug test during development of cloudfoundry/stratos#4842, which always set the product name on the 'About' page of Stratos to 'Zuun'.
I also took this chance to add an appropriate piece of missing documentation for the feature of being able to use angular customizations to add an arbitrary appName.

Motivation and Context

The change was mistakenly included in #4
Sorry for that, my bad.

How Has This Been Tested?

I started up Stratos locally and made sure that once this line is removed, the app name defaults to Stratos.
Furthermore I also tested that if you use the Customization Service, you can put any name you want and it'll show up.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

Copy link

@wayne wayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wayneeseguin wayneeseguin merged commit eb037b9 into cloudfoundry-community:develop Sep 20, 2024
2 checks passed
@norman-abramovitz
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants