Skip to content

Commit

Permalink
Fix base image pinning from Concourse resources
Browse files Browse the repository at this point in the history
... properly using build args as advised in the docs! >_<
  • Loading branch information
bgandon committed May 11, 2024
1 parent 39ec061 commit f6d3050
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM alpine:3
ARG alpine

FROM ${alpine} AS resource

ARG VERSION
ARG BUILD_DATE
Expand All @@ -21,4 +23,4 @@ RUN chmod +x /opt/resource/out /opt/resource/in /opt/resource/check

ADD test/ /opt/resource-tests/
RUN /opt/resource-tests/all.sh \
&& rm -rf /tmp/*
&& rm -rf /tmp/*
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ VERSION ?= dev

build:
docker build \
--build-arg alpine="alpine:3" \
--build-arg BUILD_DATE="$(shell date -u --iso-8601)" \
--build-arg VCS_REF="$(shell git rev-parse --short HEAD)" \
--build-arg VERSION="$(VERSION)" \
Expand Down

0 comments on commit f6d3050

Please sign in to comment.