-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default D1 export to --local #7694
Conversation
🦋 Changeset detectedLatest commit: 4791a5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-wrangler-7694 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7694/npm-package-wrangler-7694 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-wrangler-7694 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-workers-bindings-extension-7694 -O ./cloudflare-workers-bindings-extension.0.0.0-vf43a39eab.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf43a39eab.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-create-cloudflare-7694 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-kv-asset-handler-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-miniflare-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-pages-shared-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-unenv-preset-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-vitest-pool-workers-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-workers-editor-shared-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-workers-shared-7694 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12678013135/npm-package-cloudflare-workflows-shared-7694 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
b7a4e3a
to
f5fc7f1
Compare
IMO this is a very breaking change (all users using D1 export will suddenly be exporting their local DB instead of their remote DB). Because of that, is this planned to be a major version bump? Landing this in a minor/patch has the potential to disrupt many user workflows. |
This is not a breaking change. This is a feature enhancement where if |
To be clear,
IMO this is a |
f5fc7f1
to
992a22d
Compare
992a22d
to
57a10b4
Compare
For posterity, merging with a failing C3 check because this PR doesn't touch C3 and the same test is failing (flaking, probably) on main |
Copy behavior of
wrangler d1 execute
forwrangler d1 export
.