Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D1] Adding information on D1PreparedStatement object. #19051

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[D1] Adding information on D1PreparedStatement object. #19051

merged 3 commits into from
Jan 7, 2025

Conversation

Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Jan 7, 2025

Summary

Previously, docs stated that the prepare() method returned none, which is incorrect - it actually returns a D1PreparedStatement. This PR corrects this information.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@Oxyjun Oxyjun requested review from elithrar, rozenmd, vy-ton, joshthoward and a team as code owners January 7, 2025 16:21
@github-actions github-actions bot added the product:d1 D1: https://developers.cloudflare.com/d1/ label Jan 7, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82a3cf6
Status: ✅  Deploy successful!
Preview URL: https://e06bbd19.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://jun-d1-prepared-statement-fi.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/d1/worker-api/prepared-statements/ https://jun-d1-prepared-statement-fi.cloudflare-docs-7ou.pages.dev/d1/worker-api/prepared-statements/
https://developers.cloudflare.com/d1/worker-api/d1-database/ https://jun-d1-prepared-statement-fi.cloudflare-docs-7ou.pages.dev/d1/worker-api/d1-database/

@github-actions github-actions bot added size/m and removed size/xs labels Jan 7, 2025
@Oxyjun Oxyjun merged commit 91a25f0 into production Jan 7, 2025
12 checks passed
@Oxyjun Oxyjun deleted the jun/d1/prepared-statement-fix branch January 7, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcpena dcpena dcpena approved these changes

@lambrospetrou lambrospetrou lambrospetrou approved these changes

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@rozenmd rozenmd Awaiting requested review from rozenmd rozenmd is a code owner

@vy-ton vy-ton Awaiting requested review from vy-ton vy-ton is a code owner

@joshthoward joshthoward Awaiting requested review from joshthoward joshthoward is a code owner

Assignees

@elithrar elithrar

@rozenmd rozenmd

@joshthoward joshthoward

@vy-ton vy-ton

@Oxyjun Oxyjun

Labels
product:d1 D1: https://developers.cloudflare.com/d1/ size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Oxyjun @lambrospetrou @dcpena @elithrar @rozenmd @joshthoward @vy-ton