-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D1] Creating proper API documentation #17923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, 4 total issue(s) found.
Deploying cloudflare-docs with Cloudflare Pages
|
This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thrilled we're finally get D1 API separate docs, left a few suggestions, good to merge after
Co-authored-by: marciocloudflare <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending my comments. This is some substantial work. Awesome!
* Adding placeholder for new API section. * Initializing await stmt API chapter. * Reordering the sidebar. Adding intro to stmt.methods. * Setting up Worker Bindings API chapters. * Settling on naming convention, fleshing out .db chapter. * Setting up the database API section. * Fleshing out API chapters. * Updating D1 API docs. * Adding in more information to be complete. * Apply suggestions from code review Co-authored-by: Lambros Petrou <[email protected]> * Update src/content/docs/d1/worker-api/query.mdx * Updating the Return Object chapter. Testing more APIs. * Fleshing out the API docs in more detail. * Fixing broken link. * Changing reference to mention Worker Binding APIs. * Small rename. * Small rename. * Updating the chapters * Modifying the structure to align with discussion. * Renaming extensions header for better clarity. * Adding changelog entry for including multiple queries in a single prepared statement. * Updating wording in Get started to match new folders. * Fixing broken link * Implementing feedback. * Removing references to multi-statement prepare(). * Fixing broken links * Grammar fixes and deleting redundant comment block. * Apply suggestions from code review Co-authored-by: marciocloudflare <[email protected]> * Minor rename of the chapter * Cleaning up the structure by method hierarchy. * Adding a note for those who are following the tutorial with an existing Worker. * Actioning PR feedback. * Turning all method names into links to the relevant header. --------- Co-authored-by: Lambros Petrou <[email protected]> Co-authored-by: marciocloudflare <[email protected]>
Summary
At the moment, this is purely additive. This causes duplication in the content, between "Query D1" chapter. We will have to tackle "Build with D1" on a separate PR.
Screenshots (optional)
Before (left) and after (right)
Expanded new sidebar folders:
Documentation checklist