Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "krb_host" as a config option #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IsaacDim
Copy link

Describe your changes

Added "krb_host" as an optional parameter for Hive connections that use Kerberos as their authentication type.

Internal Jira ticket number or external issue link

Issue from @Mac-lp3 #153

Testing procedure/screenshots(if appropriate):

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@IsaacDim
Copy link
Author

Hi, this PR was made with @Mac-lp3.

We're not quite sure how to go about testing this change though. Are the changes to conftests.py sufficient?

@IsaacDim IsaacDim marked this pull request as ready for review May 21, 2024 02:16
@Mac-lp3
Copy link

Mac-lp3 commented May 30, 2024

Hi @niteshy,

This PR is for that separate kerberos host issue we spoke about ~last week (#153).

I got someone to submit the PR for me 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants