Add --x-google-api-name argument to legacy get_swagger_spec command. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the option, the command fails to read parsed arguments. Fixes cloudendpoints#189
inklesspen
suggested changes
Mar 13, 2019
There was a problem hiding this comment.
get_swagger_spec ought to be deprecated, though; there should be no need for people to call it instead of get_openapi_spec. Can you change the function for get_swagger_spec to a wrapper that prints a deprecation warning and then calls the underlying _GenOpenApiSpecCallback?
All users should invoke get_openapi_spec instead.
|
I added the deprecation warning. |
inklesspen
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the option, the command fails to read parsed arguments.
Fixes #189