Revert "Make trailing slash truly optional." #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inklesspen
added a commit
that referenced
this pull request
Mar 13, 2018
Squashed commit of the following: commit 7fd92d3 Author: Rose Davidson <[email protected]> Date: Tue Mar 13 11:35:36 2018 -0700 Revert "Make trailing slash truly optional. (#142) (#143)" This reverts commit 818c925. Reverted because the author told me he'd found this produces parsing issues: > It seems now patterns like /prefix/{var1}/{var2}/ and /prefix/{var1}/ are mixed up. May reconsider this approach later.
|
This was actually merged, via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 818c925.
Reverted because the author told me he'd found this produces parsing issues:
May reconsider this approach later.
This reverts #143 and reopens #142.