Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync release leadership on stop #871

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Sync release leadership on stop #871

merged 3 commits into from
Dec 12, 2024

Conversation

carlhoerberg
Copy link
Member

WHAT is this pull request doing?

Synchronous release the release leadership when shutting down gracefully.

HOW can this pull request be tested?

Specs

Fixes #869

@carlhoerberg carlhoerberg requested a review from a team as a code owner December 9, 2024 11:33
@carlhoerberg
Copy link
Member Author

Instead of wait loops self maybe it should return false when timeout and true when lost?

@spuun
Copy link
Member

spuun commented Dec 9, 2024

Instead of wait loops self maybe it should return false when timeout and true when lost?

Yes, i think that would be more clear.

@spuun spuun mentioned this pull request Dec 10, 2024
Open
@carlhoerberg carlhoerberg merged commit d28ee85 into main Dec 12, 2024
21 of 25 checks passed
@carlhoerberg carlhoerberg deleted the sync-release-leadership-on-stop branch December 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spuun spuun spuun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlhoerberg @spuun