feat(details): round line item amount by 2 decimal points #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-kuen
requested changes
Jun 2, 2024
src/details.rs
Outdated
| @@ -84,7 +84,7 @@ impl<'a> DetailsItem<'a> { | |||
| None => Decimal::ZERO, | |||
| }; | |||
|
|
|||
| self.quantity * self.unit_price / base_quantity + reduction_and_surcharge_sum | |||
| (self.quantity * self.unit_price / base_quantity + reduction_and_surcharge_sum).round_dp(2) | |||
There was a problem hiding this comment.
round_dp uses Bankersrounding: 6.5 -> 6
We should use clone_with_scale here. It uses MidpointAwayFromZero rounding.
Also this may affect line_item_total_gross_amount results due to previous rounding.
I think we should round right when creating the TaxItem elements.
There was a problem hiding this comment.
I just changed it to use the round_dp_with_strategy to round with MidpointAwayFromZero strategy. I wanted to use this method instead of clone_with_scale because it is directly implemented by rust_decimal and does the same.
Regarding line_item_total_gross_amount I think it is totally fine to use rounded line items as we should always calculate with the values you see on the invoice in the end.
…neItemAmount xml field the decimal is already rounded
p-kuen
changed the title
d-kuen
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3