Licensing support #1337
Merged
Licensing support #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, modified provider-kubeconfig generator to include https in the provided API server IP only if it is not already present.
In the original design, we were using the output of kubectl connections to find out the Pods and then running metrics and logs on those Pods. However, for workloads in which Pods get created at runtime, connections is not able to find all the newly created workload Pods. This leads to incomplete results for metrics and logs. A simple way to handle this is to use all the pods in the namespace in which the application pods are running for collecting logs and metrics. The runtime Pods are typically created in the same namespace in which the application is running. This will give accurate results (atleast more accurate than using the output of kubect connections for the list of Pods). Fixes: #1190
Merge branch 'master' into develop
Fixes: #1208
Service name check
Added a field ('error') to the status object.
This is used by helmer to store any errors that
are encountered when performing helm upgrade.
It provides a UI for managing application instances. But it does not run on the cluster. The open-source equivalent is consumerUI, which is deployed as part KubePlus deployment.
Fixes: #1222
- Added link to Contributing guidelines. These guidelines contain pointer to setting up development environment - Extracted Architecture in a separate section - Updated link to CNCF Application definition section - Added Getting Started section Fixes: #1221
devdattakulkarni
commented
Aug 3, 2024
deploy/kubeconfiggenerator.py
Outdated
|
|
||
| msg = "" | ||
|
|
||
| cmd1 = "kubectl get " + kind |
There was a problem hiding this comment.
Move this evaluation below line 1222.
devdattakulkarni
commented
Aug 3, 2024
plugins/crlicense.py
Outdated
| appinstances = '' | ||
| if args.appinstances: | ||
| appinstances = args.appinstances | ||
| if int(appinstances) < 0: |
There was a problem hiding this comment.
Change this to <=
devdattakulkarni
commented
Aug 3, 2024
plugins/kubectl-license-delete
Outdated
| @@ -0,0 +1,56 @@ | |||
| #!/bin/bash | |||
|
|
|||
| #python3 crlicense.py delete "$@" | |||
devdattakulkarni
commented
Aug 3, 2024
plugins/kubectl-license-get
Outdated
| @@ -0,0 +1,58 @@ | |||
| #!/bin/bash | |||
|
|
|||
| #python3 crlicense.py get "$@" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.