Retrieve application and pod statuses #1332
Conversation
|
@omgoswami 👍 |
|
I'm not sure why it's trying to merge 9 commits instead of only the most recent one -- any idea what's going on? |
|
Check https://github.com/orgs/community/discussions/22787 for why this happens There is no need to worry as long as the files shown/included as part of the PR are the ones that you have actually modified as part this issue's work. |
plugins/appstatus.py
Outdated
|
|
||
| Input: name of kind and name of application instance | ||
|
|
||
| TODO: reexamine all error checks for plugins |
plugins/appstatus.py
Outdated
| or check if status contains an error | ||
| otherwise (i.e. status missing), display "App not deployed properly" | ||
| ''' | ||
| # response = json.dumps(json.loads(out), indent=4) |
devdattakulkarni
changed the title
plugins/crmetrics.py
Outdated
| return True | ||
| return False | ||
|
|
||
| ''' |
There was a problem hiding this comment.
Do we need this TODO?
There was a problem hiding this comment.
No, I'm removing it now -- the method that that TODO describes was written right below it.
tests/tests.py
Outdated
| out, err = TestKubePlus.run_command(cmd) | ||
|
|
||
| # test plugin | ||
| cmd = "kubectl appstatus HelloWorldService hs1" |
There was a problem hiding this comment.
Don't we have to pass "-k provider.conf" here?
There was a problem hiding this comment.
While I was testing locally, it worked without -k provider.conf (as does appresources), but I will add it in.
tests/tests.py
Outdated
|
|
||
| def cleanup(): | ||
| cmd = "cd ./hello-world" |
There was a problem hiding this comment.
tests/tests.py
Outdated
| # TODO: Add tests for | ||
| # kubectl connections | ||
| # kubectl appresources | ||
| # kubectl appurl | ||
| # kubectl applogs | ||
| # kubectl metrics | ||
| # TODO: pos test case for kubectl appstatus with HelloWorld |
There was a problem hiding this comment.
You can delete this TODO.
|
|
||
| # test plugin | ||
| cmd = "kubectl appstatus HelloWorldService hs1" | ||
| out, err = TestKubePlus.run_command(cmd) |
There was a problem hiding this comment.
Can we write some assertions on the output?
Also, it will be good to print the output. That way, in the CI run we will be able to see how the output looks like.
| @@ -0,0 +1,53 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
You have made this file executable, right? (chmod +x kubectl-appstatus)
plugins/appstatus.py
Outdated
| print(err) | ||
| exit(1) | ||
|
|
||
| release_name_or_status, release_ns, deployed, err = appStatusFinder.get_app_instance_status(kind, instance, kubeconfig) |
There was a problem hiding this comment.
Don't need the last parameter since it is always returned as None.
plugins/appstatus.py
Outdated
| exit(1) | ||
|
|
||
| release_name_or_status, release_ns, deployed, err = appStatusFinder.get_app_instance_status(kind, instance, kubeconfig) | ||
| if err is not None: |
There was a problem hiding this comment.
Don't need this check. The error check is happening in lines 12-15.
plugins/appstatus.py
Outdated
| else: | ||
| # an error has occurred | ||
| status = response['status'] | ||
| return status, None, False, None |
There was a problem hiding this comment.
I suggest defining variables for the second and third return parameters and setting their values after lines 21 and 25. That way, by looking at the return statement it will be clear what parameters are being returned.
|
Also, while the CI is passing, it might be because we don't have any asserts on the output in the test. So let's add some asserts on the output. There is also the below error in the CI run. I am not sure why it did not cause CI failure. https://github.com/cloud-ark/kubeplus/actions/runs/10203383316/job/28229600641?pr=1332#step:5:4792 |
…estions on plugins/appstatus.py
|
|
||
| # asserts | ||
| lines = out.split('\n') | ||
| self.assertTrue('Deployed' in lines[1]) |
There was a problem hiding this comment.
Is the order of the lines always guaranteed to be such that the first line will be helm release and the second line will be Pods?
There was a problem hiding this comment.
Checking this now.
There was a problem hiding this comment.
Yes! In the driver code for the plugin in plugins/appstatus.py, I am printing the helmrelease first and then iterating through all of the pods in the namespace afterwards.
tests/tests.py
Outdated
| return | ||
|
|
||
| # register HelloWorldService API | ||
| cmd = "kubectl create -f ../examples/multitenancy/hello-world/hello-world-service-composition.yaml --kubeconfig=%s" % provider |
There was a problem hiding this comment.
Change this to:
hello-world-service-composition-local.yaml.
hello-world-service-composition uses the 0.0.2 version of the chart.
hello-world-service-composition-local uses the 0.0.3 version of the chart.
The 0.0.3 version of the chart has replicas field in values.yaml
tests/tests.py
Outdated
| def cleanup(): | ||
| cmd = "kubectl delete -f ../examples/multitenancy/hello-world/hs1.yaml --kubeconfig=%s" % provider | ||
| TestKubePlus.run_command(cmd) | ||
| cmd = "kubectl delete -f ../examples/multitenancy/hello-world/hello-world-service-composition.yaml --kubeconfig=%s" % provider |
There was a problem hiding this comment.
Change this to: hello-world-service-composition-local.yaml
added
kubectl appstatusplugin which will validate the given instance of an application and return its status, along with the status of any application pods