Move =? cond to function to reduce generated code #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahTheDuke
commented
Nov 22, 2024
| @@ -218,7 +222,7 @@ | |||
| a#)}) | |||
| (t/do-report | |||
| {:type :fail, | |||
| :message (if m# (if ~msg (str ~msg "\n" m#) m#) ~msg) | |||
| :message (if m# (if-let [msg# ~msg] (str msg# "\n" m#) m#) ~msg) | |||
There was a problem hiding this comment.
Also evals msg once so it doesn't put a potentially big msg in multiple times (in addition to wasting effort executing it multiple times).
|
Have you made this change to LazyTest too, since you copied over a bunch of Expectations stuff? |
seancorfield
added a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Sean Corfield <[email protected]>
|
Yeah I'm gonna move this over when I get a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to NoahTheDuke/lazytest#13, this moves the big
condblock from=?to a separate function, which reduces generated code size. I also changed the msg generation to be eager so(pr-str e')and(pr-str (list 'expect e' a))don't bloat the generated code either.