fix: cache opts.cwd so it cannot be changed by another function #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cljoly
reviewed
Mar 20, 2024
I'm not sure why but for me opts.cwd reverted back to my home directory in the make_display function (while it's correct in the gen_from_fd function). By caching it this way, it works fine 🤷 See also cljoly#70
|
@entropitor I’ve slightly edited your PR to add a comment. Your fix makes sense, thanks for contributing this patch! |
|
Okay, awesome! I think the culprit might be this one by the way , maybe that should beopts.cwd = opts.cwd or vim.env.HOME?
|
cljoly
added a commit
that referenced
this pull request
Apr 25, 2024
Sometimes, when we cache opts.cwd, it is still nil. While this problem is investigated [separately][1], it’s worth having this workaround, to be on the safe side. It’s very disruptive when items can’t be diplayed. [1]: #70 (comment) Originally authored by @rish987 in #71. I’ve made cosmetic changes and added some comments. Co-authored-by: Rishikesh Vaishnav <[email protected]>
cljoly
added a commit
that referenced
this pull request
Apr 25, 2024
Sometimes, when we cache opts.cwd, it is still nil. While this problem is investigated [separately][1], it’s worth having this workaround, to be on the safe side. It’s very disruptive when items can’t be diplayed. [1]: #70 (comment) Originally authored by @rish987 in #71. I’ve made cosmetic changes and added some comments. Co-authored-by: Rishikesh Vaishnav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why but for me
opts.cwdreverted back to my home directory in the make_display function (while it's correct in thegen_from_fdfunction). By caching it this way, it works fine 🤷