update deploy scripts to v2.0.0 #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
elr/ops-v1.1.1.rc1-testing
branch
from
6cecd59 to
f8cd611
Compare
elrayle
force-pushed
the
elr/ops-v1.1.1.rc1-testing
branch
from
f8cd611 to
fad9048
Compare
qtomlinson
approved these changes
Jul 11, 2024
qtomlinson
changed the title
qtomlinson
approved these changes
Jul 11, 2024
| @@ -7,8 +7,23 @@ on: | |||
| branches: [master] | |||
|
|
|||
| jobs: | |||
| upload-package-lock-json: | |||
| name: Upload package-lock.json from this repo | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
This uploading job is somewhat cumbersome. Hopefully, we can improve this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155
Description
The v2.0.0 deploy workflows moved many of the complex scripts to files that can be tested. This identified several bugs that when fixed allowed the service-dev to deploy successfully. The change also adds a new job to upload the package-lock.json file to the build artifacts. This is needed for the build-and-deploy job to be able to get the version from that file.
Related Work