for docker hub image, include latest tag #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljones140
approved these changes
Oct 31, 2024
elrayle
force-pushed
the
elr/tag-latest
branch
2 times, most recently
from
0b25a00 to
81c5c31
Compare
The current production crawler uses the latest tag in Docker Hub to get the image to use. When the process switches to using ghcr.io, it will use the version tag. move tag from determine-image-name to ghcr and docker hub steps
elrayle
force-pushed
the
elr/tag-latest
branch
from
81c5c31 to
4490e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the crawler prod image not updating on deploy. This was caused by the current production crawlers use of the latest tag in Docker Hub to get the image to use and the deploy process through GH workflow not creating that tag.
Expected
On release of crawler prod, the deploy should update the production crawlers to the new release version.
Actual
On release of crawler prod, the deploy has no effect on the production crawlers.
Fix
Update the GH workflow process to create the
latesttag in Docker Hub. The prod crawlers will be triggered to grab the new latest image and restart.Testing
Follow-on
Update refs to this workflow to a new release version of operations that includes this PR. And then cut a release at that version that includes this and the PR that updates the version.
CC: @ljones140