Merge pull request #79 from qtomlinson/qt/fix_comparison

Improve definition comparison
clearlydefined · Jun 10, 2024 · f8cff80 · f8cff80
2 parents 7a47b07 + b3391a3
commit f8cff80
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/tools/integration/test/e2e-test-service/definitionTest.js b/tools/integration/test/e2e-test-service/definitionTest.js
@@ -1,7 +1,7 @@
 // (c) Copyright 2024, SAP SE and ClearlyDefined contributors. Licensed under the MIT license.
 // SPDX-License-Identifier: MIT
 
-const { omit, isEqual } = require('lodash')
+const { omit, isEqual, pick } = require('lodash')
 const { deepStrictEqual, strictEqual } = require('assert')
 const { callFetch, buildPostOpts } = require('../../lib/fetch')
 const { devApiBaseUrl, prodApiBaseUrl, expectedResponses, components, definition } = require('../testConfig')
@@ -77,14 +77,16 @@ function compareDefinition(recomputedDef, expectedDef) {
 }
 
 function compareLicensed(result, expectation) {
-  const actual = omit(result.licensed, ['facets'])
+  let actual = omit(result.licensed, ['facets'])
   const expected = omit(expectation.licensed, ['facets'])
+  actual = pick(actual, Object.keys(expected))
   deepStrictEqual(actual, expected)
 }
 
 function compareDescribed(result, expectation) {
-  const actual = omit(result.described, ['tools'])
+  let actual = omit(result.described, ['tools'])
   const expected = omit(expectation.described, ['tools'])
+  actual = pick(actual, Object.keys(expected))
   deepStrictEqual(actual, expected)
 }