Upgrade Azure Storage SDK to a modern version #629
+649
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
reviewed
Dec 13, 2024
Comment on lines
+105
to
+106
| const properties = await this.queueClient.getProperties() | ||
| return { count: properties.approximateMessagesCount } |
There was a problem hiding this comment.
This likely applies in other places as well. In the original code, error handling logged the error. In the new code, it appears that error handling depends on how await handles exceptions instead of using try and catch blocks to log the error in the same way as the original.
Suggested change
| const properties = await this.queueClient.getProperties() | |
| return { count: properties.approximateMessagesCount } | |
| try { | |
| const properties = await this.queueClient.getProperties() | |
| return { count: properties.approximateMessagesCount } | |
| } catch (error) { | |
| this.logger.error(error) // Log the error | |
| return null // Handle the error by returning null | |
| } |
| if (connectionString) { | ||
| this.client = QueueServiceClient.fromConnectionString(connectionString, pipelineOptions) | ||
| } else { | ||
| this.client = new QueueServiceClient( |
There was a problem hiding this comment.
This is a nice update here for maintaining the old approach and setting up a more flexible long term approach.
| const retryOperations = new AzureStorage.ExponentialRetryPolicyFilter() | ||
| this.client = AzureStorage.createQueueService(connectionString).withFilter(retryOperations) | ||
| constructor(connectionString, options) { | ||
| const pipelineOptions = { |
There was a problem hiding this comment.
I like the use of pipelineOptions. Makes it easier to see the configs related to the queues.
| } | ||
|
|
||
| // This API can only be used for the 'deadletter' store because we cannot look up documents by type performantly | ||
| async count(type, force = false) { |
There was a problem hiding this comment.
Can you talk about the reason this is deleted completely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a prerequisite to enable token-based authentication for the Azure Storage operations (blobs and queues). This change leaves the options to use the existing, connection string-based authentication though.