Allows runtime configuration of vault provider retry delay and tries. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisunw
reviewed
Jan 4, 2024
rtjoseph11
reviewed
Jan 4, 2024
adisunw
reviewed
Jan 4, 2024
|
Would there be any objections if I were to up the default timeout to 300 from 2? @adisunw @rtjoseph11 |
I think I would prefer a change in the default |
|
I think we should set default timeout to 60 seconds and tries to 5 |
…t calls. Timeout set to 60 seconds, retries to 5.
Vishesh-Gupta
approved these changes
Jan 11, 2024
adisunw
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent issues on sync jobs caused by the Vault connectivity issues that are leading to timeouts, the ability to extend the timeout is desired. The existing implementation does not allow this at runtime due its use of decorators. This PR uses the retry_api.retry_call to facilitate runtime specification of delay and tries for retry.