Fix nested key plus default bug, fix typo in README.md, bump version #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisunw
reviewed
Oct 18, 2023
adisunw
reviewed
Oct 18, 2023
| @@ -395,15 +395,18 @@ def __get( | |||
| ) | |||
| split_keys = key.split(self.__delim_char) | |||
| consider_keys = list() | |||
| config_val = None | |||
| for split_key in split_keys: | |||
| consider_keys.append(split_key) | |||
| joined_key = self.__delim_char.join(consider_keys) | |||
| config_val = self._get_config_for_key(key=key, | |||
There was a problem hiding this comment.
hmm, does the self._get_config_for_key call here not return the default value ever? At least thats what i'm inferring from your additional logic on line 406.
There was a problem hiding this comment.
The problem here is that it returns the default value at the first val, given 'test.foo' and a default, it will never return the value of 'test.foo' always the default.
SparkeyG
force-pushed
the
sparkeyg/issue-38/nested-key-default-fix
branch
2 times, most recently
from
6e09ef1 to
fb2f0b9
Compare
rkcs21
approved these changes
Oct 18, 2023
adisunw
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.