Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap quit to ctrl+q to prevent accidental exit #35

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

clcollins
Copy link
Owner

@clcollins clcollins commented Apr 16, 2024

This PR remaps the quitting the app from q to ctrl+q to prevent accidental exit of the application.

Follow up work for more complicated key mapping (eg vim or tmux-style) will be done via #22

Fixes #32

Maintains the ability to send an incident list to SilenceIncidentsMsg, but adds SilenceSelectedIncidentMsg to handle individual incident silence via keypress, fixing a bug where the parsing of the selected incident didn't happen on time, causing a panic.
This PR remaps the quitting the app from `q` to `ctrl+q` to prevent accidental exit of the application.

Follow up work for more complicated key mapping (eg vim or tmux-style) will be done via #22

Fixes #32
@clcollins clcollins changed the title fix 10 exit confirm Remap quit to ctrl+q to prevent accidental exit Apr 16, 2024
@clcollins clcollins merged commit ada3d2b into main Apr 16, 2024
@clcollins clcollins deleted the fix_10_exit_confirm branch May 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usability - Add a confirmation to see if you want to exit the program
1 participant