Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTRL^X COMMAND keymaps #22

Open
clcollins opened this issue Mar 7, 2024 · 0 comments
Open

Add CTRL^X COMMAND keymaps #22

clcollins opened this issue Mar 7, 2024 · 0 comments

Comments

@clcollins
Copy link
Owner

In order to expand available keystrokes available for commands, and to group related commands, SREPD needs to implement CTRL^X COMMAND support, similar to tmux or nano, or more specifically the strings of commands as in vi.

Done Criteria:

  • Pressing CTRL should begin a keymsg loop separate from the main loop, awaiting matching input.
  • A matching key command should do the same, looking for a final keypress
  • Related commands should be grouped under the first CTRL+X keypress, (X being a placeholder here)

Eg:

  • CTRL + o (open browser ...)
  • CTRL + o + p (open pagerduty incident in browser)
  • CTRL + o + s (open SOP in browser)
clcollins added a commit that referenced this issue Apr 16, 2024
@clcollins
remap quit to ctrl+q to prevent accidental exit
2e76216 
This PR remaps the quitting the app from `q` to `ctrl+q` to prevent accidental exit of the application.

Follow up work for more complicated key mapping (eg vim or tmux-style) will be done via #22

Fixes #32
@clcollins clcollins mentioned this issue Apr 16, 2024
Merged
clcollins added a commit that referenced this issue Apr 16, 2024
@clcollins
Remap quit to ctrl+q to prevent accidental exit (#35)
ada3d2b 
* Fix bug silencing selected incident

Maintains the ability to send an incident list to SilenceIncidentsMsg, but adds SilenceSelectedIncidentMsg to handle individual incident silence via keypress, fixing a bug where the parsing of the selected incident didn't happen on time, causing a panic.

* remap quit to ctrl+q to prevent accidental exit

This PR remaps the quitting the app from `q` to `ctrl+q` to prevent accidental exit of the application.

Follow up work for more complicated key mapping (eg vim or tmux-style) will be done via #22

Fixes #32
clcollins added a commit that referenced this issue Apr 16, 2024
@clcollins
remap silence to prevent accidental silencing
e74c170 
This PR remaps silencing to `ctrl+s` to prevent accidental silencing of alerts, prior to #22 being worked on for vim- or tmux-style command combination.
@clcollins clcollins mentioned this issue Apr 16, 2024
Merged
clcollins added a commit that referenced this issue Apr 16, 2024
@clcollins
remap silence to prevent accidental silencing (#36)
46b56e8 
This PR remaps silencing to `ctrl+s` to prevent accidental silencing of alerts, prior to #22 being worked on for vim- or tmux-style command combination.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clcollins