-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: making default datastore optional #597
feat: making default datastore optional #597
Conversation
✅ Deploy Preview for kamaji-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fdde0a7
to
079f604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prometherion what about to have default datastore disabled by default?
That would be very bad: even tho we released the v1.0.0 as stable and we have safe defaults for beginners, I would avoid providing a stumped Kamaji with no Datastore. I'm expecting to get an HCP architecture just with a single command, without the complexity of installing the |
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
079f604
to
fd3185e
Compare
Just tested, when creating a
If you restart the Kamaji Operator with the If CI is green, happy to get this merged. |
@bsctl this change is required to support the DataStore Scheduler enterprise addon we aim to release.
After this change, Kamaji can be started with no
--datastore
field, forcing a Datastore assignment from user or addons.