Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump ibc-go from 7.4.0 to 7.4.1 #506

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

inon-man
Copy link
Collaborator

@inon-man inon-man commented Jul 31, 2024

Summary of changes

  • Bump ibc-go to classic-terra/[email protected] and go version to 1.22
  • Fix golangci-lint
  • Update Mergify rules for backporting

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@inon-man inon-man self-assigned this Jul 31, 2024
@inon-man inon-man marked this pull request as ready for review July 31, 2024 07:20
@inon-man inon-man removed security Security concerns backport/v3.0.x labels Jul 31, 2024
Copy link
Collaborator

@fragwuerdig fragwuerdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Thanks for the contribution! I presume this is a state machine breaking upgrade, is it not? In this case due to the decentralized nature of Terra Classic the current "standard procedure" to do such an upgrade is to force a chain halt through an upgrade proposal and then install the new client with an empty upgrade handler in place... In this case the PR would lack of an upgrade handler... Maybe you can give a bit feedback on this matter?

go.mod Show resolved Hide resolved
@inon-man
Copy link
Collaborator Author

inon-man commented Aug 1, 2024

Looks good from my side. Thanks for the contribution! I presume this is a state machine breaking upgrade, is it not? In this case due to the decentralized nature of Terra Classic the current "standard procedure" to do such an upgrade is to force a chain halt through an upgrade proposal and then install the new client with an empty upgrade handler in place... In this case the PR would lack of an upgrade handler... Maybe you can give a bit feedback on this matter?

There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22

@inon-man inon-man requested a review from phamminh0811 August 1, 2024 15:50
@StrathCole
Copy link
Collaborator

There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22

When looking at the code diffs from 7.4.0 I would assume it could be state breaking due to different handling of events.

@inon-man
Copy link
Collaborator Author

inon-man commented Aug 1, 2024

There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22

When looking at the code diffs from 7.4.0 I would assume it could be state breaking due to different handling of events.

Emitting events doesn't break the state. You can test it by adding any events after any messages

For example when I added a test event after in the SendCoins function in my local

	ctx.EventManager().EmitEvents(sdk.Events{
		sdk.NewEvent(
			"test",
			sdk.NewAttribute("attr1", "1"),
		),
	})

The result of querying the tx:

height: 18800267,
txhash: 'B6284253928FB8F3CF641B6A53979E9C3E6669E0AA8D93445FB6286344D85E64',
raw_log: '[{"msg_index":0,"events":[{"type":"message","attributes":[{"key":"action","value":"/cosmos.staking.v1beta1.MsgDelegate"},{"key":"sender","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"module","value":"staking"}]},{"type":"coin_spent","attributes":[{"key":"spender","value":"terra1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8pm7utl"},{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"}]},{"type":"coin_received","attributes":[{"key":"receiver","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"}]},{"type":"transfer","attributes":[{"key":"recipient","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"sender","value":"terra1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8pm7utl"},{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"}]},{"type":"message","attributes":[{"key":"sender","value":"terra1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8pm7utl"}]},**{"type":"test","attributes":[{"key":"attr1","value":"1"}]}**,{"type":"withdraw_rewards","attributes":[{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"},{"key":"validator","value":"terravaloper1259cmu5zyklsdkmgstxhwqpe0utfe5hhyty0at"},{"key":"delegator","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"}]},{"type":"coin_spent","attributes":[{"key":"spender","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"amount","value":"1991000000000uluna"}]},{"type":"coin_received","attributes":[{"key":"receiver","value":"terra1fl48vsnmsdzcv85q5d2q4z5ajdha8yu3nln0mh"},{"key":"amount","value":"1991000000000uluna"}]},{"type":"delegate","attributes":[{"key":"validator","value":"terravaloper1259cmu5zyklsdkmgstxhwqpe0utfe5hhyty0at"},{"key":"delegator","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"amount","value":"1991000000000uluna"},{"key":"new_shares","value":"1991000000000.000000000000000000"}]}]}]',

Which type:"test" can't be found on https://finder.terraclassic.community/mainnet/tx/b6284253928fb8f3cf641b6a53979e9c3e6669e0aa8d93445fb6286344d85e64

@inon-man
Copy link
Collaborator Author

inon-man commented Aug 2, 2024

I don't think these should be applied immediately. I was thinking about making them included by governance in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants