-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump ibc-go from 7.4.0 to 7.4.1 #506
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. Thanks for the contribution! I presume this is a state machine breaking upgrade, is it not? In this case due to the decentralized nature of Terra Classic the current "standard procedure" to do such an upgrade is to force a chain halt through an upgrade proposal and then install the new client with an empty upgrade handler in place... In this case the PR would lack of an upgrade handler... Maybe you can give a bit feedback on this matter?
There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22 |
When looking at the code diffs from 7.4.0 I would assume it could be state breaking due to different handling of events. |
Emitting events doesn't break the state. You can test it by adding any events after any messages For example when I added a test event after in the SendCoins function in my local
The result of querying the tx:
Which |
I don't think these should be applied immediately. I was thinking about making them included by governance in the future. |
Summary of changes
(FOR ADMIN) Before merging