Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump circuit-notation version #61

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

martijnbastiaan
Copy link
Member

@martijnbastiaan martijnbastiaan commented Feb 14, 2024

TODO:

  • Compile with -Werror on CI (also see Use -Werror on CI #62)
  • Documentation on Tagged stuff
  • Fix warnings produced by circuit-notation No warnings on currently supported GHC versions
  • Module documentation
  • Sensible tuple sizes for instances
  • Fix 2-tuple documentation issue

@martijnbastiaan martijnbastiaan changed the title Bump CircuitNotation version Bump circuit-notation version Feb 14, 2024
@martijnbastiaan martijnbastiaan force-pushed the bump-circuit-notation branch 3 times, most recently from 07026a9 to f29173d Compare February 15, 2024 08:22
@martijnbastiaan martijnbastiaan marked this pull request as ready for review February 15, 2024 08:25
Copy link
Member

@kleinreact kleinreact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only some minor comment in case you care about keeping your internals internal.

src/Protocols/Plugin.hs Outdated Show resolved Hide resolved
@martijnbastiaan martijnbastiaan merged commit 401ad10 into main Feb 15, 2024
6 checks passed
@martijnbastiaan martijnbastiaan deleted the bump-circuit-notation branch February 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants