add timeout to driveStandard function
#49
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydrolarus
force-pushed
the
driver-timeout
branch
from
1b380fd to
89e1a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the
wishbonePropWithModelfunction as theWishboneMasterRequests cannot be directly compared to S2M signals (as some might be lost due to timeouts), so this function now reconstructs thoseWishboneMasterRequests from the M2S signals instead.Maybe this should use a different abstraction entirely and a more precise way of tracking which "kind" of transaction happened to allow the model function to properly check all possible interactions. (Successful(Read, Write), Timeout with last request)