Introduce BiDf protocol #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the moment |
|
There seems to be some overlap with #83 ... |
This introduces a new protocol, `BiDf`, which captures the common pattern of a request `Df` channel paired with a `Df` for returning corresponding responses.
This is a useful operation for servicing requests from a number of sources with a single sink.
|
We're trying to be sensible about which protocols we add to this package, so now I also added |
Co-authored-by: Peter Lebbing <[email protected]>
lmbollen
reviewed
Sep 20, 2024
Comment on lines
+45
to
+46
| -- - There must not be a combinational path from the request channel to the | ||
| -- response channel. |
There was a problem hiding this comment.
Am I reading correctly that this disallows stateless circuits such as:
idBiDf :: Circuit (BiDf dom a a) ()
idBiDf = Circuit go
where
go ((fwd, bwd), _) = ((bwd, fwd), ())If so, why would that not be allowed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new protocol,
BiDf, which captures the common pattern of a requestDfchannel paired with aDffor returning corresponding responses.